Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AdapterFusion config flexibility #216

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Improve AdapterFusion config flexibility #216

merged 4 commits into from
Aug 13, 2021

Conversation

calpt
Copy link
Member

@calpt calpt commented Aug 6, 2021

Move AF config to ModelAdaptersConfig. It's now possible to have multiple AF setups with different configs within one model.

Also removes set_adapter_fusion_config().

@calpt
Improve AdapterFusion config flexibility.
e2bab76 
Move AF config to ModelAdaptersConfig.
Removes set_adapter_fusion_config().
@calpt calpt requested a review from hSterz August 6, 2021 13:09
hSterz
hSterz approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/transformers/adapters/configuration.py Show resolved Hide resolved
@calpt calpt merged commit 82a3d80 into adapter-hub:master Aug 13, 2021
@calpt calpt deleted the dev/af_config branch August 13, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz